Cache auth scheme resolution - #7282
Merged
Merged
Conversation
alextwoods
reviewed
Aug 17, 2026
S-Saranya1
reviewed
Aug 18, 2026
| * - Custom client-level providers bypass the cache (instanceof guard) | ||
| * - Per-request overrides bypass the cache | ||
| * - Default provider with caching doesn't break correctness | ||
| */ |
Contributor
There was a problem hiding this comment.
Worth adding a few more test cases covering:
- regionSet varies per request
- different operations get their own results
- cache hit (default provider resolves only once for repeated same-operation calls)
Contributor
Author
There was a problem hiding this comment.
Added test cases to cover these
alextwoods
approved these changes
Aug 18, 2026
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Cache deterministic auth scheme resolution results to reduce per-request CPU overhead. Auth scheme resolution is called on every request and produces the same result for a given set of inputs when using the default provider - caching avoids repeated allocation and computation.
Modifications
ConcurrentHashMap<String, List<AuthSchemeOption>> authSchemeCachefield on sync/async client classesinstanceof DefaultXxxAuthSchemeProviderregionregion + ":" + regionSetoperationName + ":" + regionoperationName + ":" + region + ":" + regionSetTesting
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License